marcus/pdf-umbenenner
1
0
Fork 0
Code Activity

Windows-Zeichenbereinigung im Basis-Dateinamen wirksam gemacht und Tests

Browse Source 
korrigiert
This commit is contained in:
Marcus van Elst
2026-04-07 14:18:18 +02:00
parent 7e4201b651
commit df0a3ad07b
2 changed files with 37 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
pdf-umbenenner-application/src/test/java/de/gecheckt/pdf/umbenenner/application/service/TargetFilenameBuildingServiceTest.java
View File

@@ -202,16 +202,35 @@ class TargetFilenameBuildingServiceTest {
}
@Test
void buildBaseFilename_titleWithSlash_returnsInconsistentProposalState() {
void buildBaseFilename_titleWithSlash_removesWindowsIncompatibleCharacterAndSucceeds() {
// Slash (/) is a Windows-incompatible character. It should be removed,
// leaving "RgStrom" which is valid (letters only)
ProcessingAttempt attempt = proposalAttempt(LocalDate.of(2026, 1, 1), "Rg/Strom");
BaseFilenameResult result = TargetFilenameBuildingService.buildBaseFilename(attempt);
assertThat(result).isInstanceOf(InconsistentProposalState.class);
assertThat(result).isInstanceOf(BaseFilenameReady.class);
assertThat(((BaseFilenameReady) result).baseFilename())
.isEqualTo("2026-01-01 - RgStrom.pdf");
}
@Test
void buildBaseFilename_titleWithMultipleWindowsChars_removesAllAndSucceeds() {
// Multiple Windows-incompatible characters (: and ") should be removed,
// leaving "Rechnung 2026" which is valid (letters, digits, and spaces)
ProcessingAttempt attempt = proposalAttempt(LocalDate.of(2026, 1, 1), "Rechnung: \"2026\"");
BaseFilenameResult result = TargetFilenameBuildingService.buildBaseFilename(attempt);
assertThat(result).isInstanceOf(BaseFilenameReady.class);
assertThat(((BaseFilenameReady) result).baseFilename())
.isEqualTo("2026-01-01 - Rechnung 2026.pdf");
}
@Test
void buildBaseFilename_titleWithDot_returnsInconsistentProposalState() {
// Dot (.) is NOT a Windows-incompatible character (as per our list < > : " / \ | ? *)
// So it remains in the cleaned title and causes validation to fail
ProcessingAttempt attempt = proposalAttempt(LocalDate.of(2026, 1, 1), "Rechnung.pdf");
BaseFilenameResult result = TargetFilenameBuildingService.buildBaseFilename(attempt);