marcus/pdf-umbenenner
1
0
Fork 0
Code Issues 14 Releases 2 Activity

SonarQube: fix alle BLOCKER- und CRITICAL-Issues (S3252, S2479, S1186, S1192, S2699, S5783, S3776)

Browse Source 
- S3252: GuiStatusRefreshTimeline nutzt Animation.INDEFINITE statt Timeline.INDEFINITE
- S2479: Narrow-No-Break-Space (U+202F) in GuiTooltipTexts durch normales Leerzeichen ersetzt
- S1186: 134 leere Stub-Methoden in 18 Test- und Produktionsdateien kommentiert
- S1192: ~49 duplizierte String-Literale in ~25 Klassen als Konstanten extrahiert
- S2699: fehlende Assertions in SqliteSchemaInitializationAdapterTest und FilesystemTargetFolderAdapterTest ergaenzt
- S5783: Lambda-geprufte Ausnahme in SqliteSchemaInitializationAdapterTest in private Hilfsmethode extrahiert
- S3776: kognitive Komplexitaet in 8 Methoden durch Methodenextraktion auf unter 15 gesenkt
  (EarlyLogDirectoryInitializer, CliArgumentParser, GuiConfigurationEditorWorkspace,
   GuiHistoryTab x2, GuiBatchRunTab x2, DefaultManualFileCopyUseCase)
- Kompilierungsfehler behoben: private-Modifier in CorrectionOutcome-Interface entfernt,
  selbstreferenzielle Konstante in ModelCatalogResult korrigiert

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcus van Elst
2026-05-06 21:27:59 +02:00
parent 14da7ee789
commit b7f9184344
49 changed files with 974 additions and 511 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pdf-umbenenner-bootstrap/src/test/java/de/gecheckt/pdf/umbenenner/bootstrap/BootstrapRunnerConfigPathSemanticsTest.java
+9 -3
View File
@@ -450,8 +450,12 @@ class BootstrapRunnerConfigPathSemanticsTest {
}
private static class MockRunLockPort implements de.gecheckt.pdf.umbenenner.application.port.out.RunLockPort {
@Override public void acquire() {}
@Override public void release() {}
@Override public void acquire() {
// intentionally empty
}
@Override public void release() {
// intentionally empty
}
@Override
public java.util.Optional<de.gecheckt.pdf.umbenenner.application.port.out.RunLockHandle> tryAcquire() {
return java.util.Optional.empty();
@@ -460,7 +464,9 @@ class BootstrapRunnerConfigPathSemanticsTest {
private static class MockSchemaInitializationPort
implements de.gecheckt.pdf.umbenenner.application.port.out.PersistenceSchemaInitializationPort {
@Override public void initializeSchema() {}
@Override public void initializeSchema() {
// intentionally empty
}
}
private static class MockRunBatchProcessingUseCase
pdf-umbenenner-bootstrap/src/test/java/de/gecheckt/pdf/umbenenner/bootstrap/BootstrapRunnerEdgeCasesTest.java
+6 -2
View File
@@ -567,10 +567,14 @@ class BootstrapRunnerEdgeCasesTest {
private static class MockRunLockPort implements RunLockPort {
@Override
public void acquire() { }
public void acquire() {
// intentionally empty
}
@Override
public void release() { }
public void release() {
// intentionally empty
}
@Override
public java.util.Optional<de.gecheckt.pdf.umbenenner.application.port.out.RunLockHandle> tryAcquire() {
pdf-umbenenner-bootstrap/src/test/java/de/gecheckt/pdf/umbenenner/bootstrap/BootstrapRunnerStartupDispatchTest.java
+9 -3
View File
@@ -256,8 +256,12 @@ class BootstrapRunnerStartupDispatchTest {
// --- Shared mock helpers (mirroring BootstrapRunnerTest pattern) ---
private static class MockRunLockPort implements de.gecheckt.pdf.umbenenner.application.port.out.RunLockPort {
@Override public void acquire() {}
@Override public void release() {}
@Override public void acquire() {
// intentionally empty
}
@Override public void release() {
// intentionally empty
}
@Override
public java.util.Optional<de.gecheckt.pdf.umbenenner.application.port.out.RunLockHandle> tryAcquire() {
return java.util.Optional.empty();
@@ -266,7 +270,9 @@ class BootstrapRunnerStartupDispatchTest {
private static class MockSchemaInitializationPort
implements de.gecheckt.pdf.umbenenner.application.port.out.PersistenceSchemaInitializationPort {
@Override public void initializeSchema() {}
@Override public void initializeSchema() {
// intentionally empty
}
}
private static class MockRunBatchProcessingUseCase
pdf-umbenenner-bootstrap/src/test/java/de/gecheckt/pdf/umbenenner/bootstrap/BootstrapRunnerTest.java
+6 -2
View File
@@ -546,10 +546,14 @@ class BootstrapRunnerTest {
private static class MockRunLockPort implements RunLockPort {
@Override
public void acquire() { }
public void acquire() {
// intentionally empty
}
@Override
public void release() { }
public void release() {
// intentionally empty
}
@Override
public java.util.Optional<de.gecheckt.pdf.umbenenner.application.port.out.RunLockHandle> tryAcquire() {
pdf-umbenenner-bootstrap/src/test/java/de/gecheckt/pdf/umbenenner/bootstrap/BootstrapSmokeTest.java
+9 -3
View File
@@ -189,8 +189,12 @@ class BootstrapSmokeTest {
// -------------------------------------------------------------------------
private static class NoOpRunLockPort implements RunLockPort {
@Override public void acquire() { }
@Override public void release() { }
@Override public void acquire() {
// intentionally empty
}
@Override public void release() {
// intentionally empty
}
@Override
public java.util.Optional<de.gecheckt.pdf.umbenenner.application.port.out.RunLockHandle> tryAcquire() {
return java.util.Optional.empty();
@@ -198,6 +202,8 @@ class BootstrapSmokeTest {
}
private static class NoOpSchemaInitializationPort implements PersistenceSchemaInitializationPort {
@Override public void initializeSchema() { }
@Override public void initializeSchema() {
// intentionally empty
}
}
}