fix: search empty results + extract error 408 (v0.3.3)
Bug 1 — search::start folder_path format (already fixed in 314fae9):
json.dumps([path]) is confirmed correct per official Synology API docs
and multiple independent implementations (N4S4/synology-api, kwent/syno).
Poll-loop last-non-empty guard (if current_files:) is also in place.
No further change needed for Bug 1.
Bug 2 — extract::start wrong parameter key:
The previous fix attempt renamed "file_path" → "path", which was wrong.
Official API docs and independent implementations confirm the key is
"file_path". The json.dumps() wrapping on file_path and dest_folder_path
was already correct. Reverted the key rename.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
[project]
|
[project]
|
||||||
name = "mcp-synology-filestation"
|
name = "mcp-synology-filestation"
|
||||||
version = "0.3.2"
|
version = "0.3.3"
|
||||||
description = "MCP server for Synology FileStation"
|
description = "MCP server for Synology FileStation"
|
||||||
requires-python = ">=3.12"
|
requires-python = ">=3.12"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
"""MCP server for Synology FileStation."""
|
"""MCP server for Synology FileStation."""
|
||||||
|
|
||||||
__version__ = "0.3.2"
|
__version__ = "0.3.3"
|
||||||
|
|||||||
@@ -845,7 +845,7 @@ def register_filestation(
|
|||||||
"start",
|
"start",
|
||||||
version=2,
|
version=2,
|
||||||
params={
|
params={
|
||||||
"path": json.dumps(file_path),
|
"file_path": json.dumps(file_path),
|
||||||
"dest_folder_path": json.dumps(dest_folder_path),
|
"dest_folder_path": json.dumps(dest_folder_path),
|
||||||
"overwrite": "true" if overwrite else "false",
|
"overwrite": "true" if overwrite else "false",
|
||||||
"keep_dir": "true" if keep_dir else "false",
|
"keep_dir": "true" if keep_dir else "false",
|
||||||
|
|||||||
@@ -1353,7 +1353,7 @@ async def test_extract_success(config: AppConfig) -> None:
|
|||||||
assert start_call[0][1] == "start"
|
assert start_call[0][1] == "start"
|
||||||
assert start_call[1]["version"] == 2
|
assert start_call[1]["version"] == 2
|
||||||
p = start_call[1]["params"]
|
p = start_call[1]["params"]
|
||||||
assert json.loads(p["path"]) == "/backup/archive.zip"
|
assert json.loads(p["file_path"]) == "/backup/archive.zip"
|
||||||
assert json.loads(p["dest_folder_path"]) == "/data/extracted"
|
assert json.loads(p["dest_folder_path"]) == "/data/extracted"
|
||||||
assert p["overwrite"] == "false"
|
assert p["overwrite"] == "false"
|
||||||
assert p["keep_dir"] == "true"
|
assert p["keep_dir"] == "true"
|
||||||
|
|||||||
Reference in New Issue
Block a user